Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: data preservers benchmarks #783

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chexware
Copy link
Contributor

This PR adds benchmarking weights for pallet_data_preservers to Dancelight

Currently there are 2 failing benchmarking case for Dancelight

  • pallet_data_preservers::start_assignment
  • pallet_data_preservers::stop_assignment

@chexware chexware added not-breaking Does not need to be mentioned in breaking changes B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Dec 11, 2024
Copy link
Contributor

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2108 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

Copy link
Contributor

Coverage Report

(master)

@@                            Coverage Diff                            @@
##           master   aleks-fix-data-preservers-benchmarking     +/-   ##
=========================================================================
  Coverage   64.76%                                   64.76%   0.00%     
  Files         323                                      323             
  Lines       55740                                    55740             
=========================================================================
  Hits        36097                                    36097             
  Misses      19643                                    19643             
Files Changed Coverage

Coverage generated Wed Dec 11 19:07:13 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant